Fixes related to GEOS 3.9 OverlayNG #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only change in code is the TransformBeforeAntimeridianToWGS84() method. Instead of intersecting the geometry with a multipolygon made of two parts, one left of the antimeridian, one right of it, but which were at a very close distance, which resulted in a LINESTRING EMPTY intersection with OverlayNG, we compute the difference between our geometry and a thin polygon around the antimeridian, which works for older GEOS too.
rouault
force-pushed
the
fixes_for_geos_overlay_ng
branch
from
04f0da2
to
79ba54e
Compare
|
Note: @pramsey fixed the issue in GEOS master ( in libgeos/geos@49ac5aa) that was triggered by the old way we cut at antimeridian . So we'd probably not need to change our code, but the new way is less convoluted, so let's just do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change in code is the TransformBeforeAntimeridianToWGS84() method.
Instead of intersecting the geometry with a multipolygon made of two parts,
one left of the antimeridian, one right of it, but which were at a very
close distance, which resulted in a LINESTRING EMPTY intersection with OverlayNG,
we compute the difference between our geometry and a thin polygon around the
antimeridian, which works for older GEOS too.