Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC 81: support for coordinate epochs in geospatial formats #3827

Merged
merged 2 commits into from Jun 18, 2021

Conversation

rouault
Copy link
Member

@rouault rouault commented May 10, 2021

No description provided.


See https://github.com/rouault/gdal/blob/coordinate_epoch/gdal/doc/source/user/coordinate_epoch.rst
for impacts on the API, encoding of CRS in a number of formats, and impacts on
existing utilities.
Copy link
Contributor

@sgillies sgillies May 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouault can we merge that doc with this one? Otherwise it is not completely clear what document we are reviewing and what is being approved. If we have a single document, we can focus on one text, not two, and don't have to consider relationships between them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge that doc with this one? Otherwise it is not completely clear what document we are reviewing and what is being approved. If we have a single document, we can focus on one text, not two, and don't have to consider relationships between them.

I see your point but the other document is intended to be in the user documentation on gdal.org once PR 3810 is merged, and potentially be evolving over time. I don't want to go through the RFC process each time we change something for a format.

@rouault
Copy link
Member Author

rouault commented May 23, 2021

The implementation on the GeoPackage side will likely change a bit as the spec editor has proposed an official way of encoding the coordinate epoch: opengeospatial/geopackage#600
==> done

@rouault
Copy link
Member Author

rouault commented May 24, 2021

@stale
Copy link

stale bot commented Jun 16, 2021

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 21 days and is being automatically marked as "stale". If you think this pull request should be merged, please check - that all unit tests are passing - that all comments by reviewers have been addressed - that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes
  • add a description of workflows which this pull request fixes
  • add screenshots if applicable
  • that you have written unit tests where possible In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request. If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale label Jun 16, 2021
@rouault
Copy link
Member Author

rouault commented Jun 17, 2021

keep alive

@stale stale bot removed the stale label Jun 17, 2021
@rouault rouault marked this pull request as ready for review June 18, 2021 14:22
@rouault rouault added this to the 3.4.0 milestone Jun 18, 2021
@rouault rouault merged commit 11a4f38 into OSGeo:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants