Simplify Makefile to build all addon subdirs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteler
reviewed
Sep 22, 2019
neteler
reviewed
Sep 22, 2019
|
The same works for the vector/Makefile etc., pls consider to expand this PR |
Yes, it would be the plan to apply this to the other AddOn types (vector, imagery, ...) as well. Now I also committed a solution for filtering out deprecated AddOns; if not building those AddOns by default is the preferred solution. However, maybe it is better to add a DEPRECATED section to the manual instead (and have addons and manuals built)? |
|
Please also update misc/Makefile, then it should be complete (and there is a conflict in grass7/raster/Makefile) |
neteler
changed the title
neteler
added a commit
that referenced
this pull request
Jan 29, 2020
* Simplify Makefile to build all i.sentinel subdirs Approach following #30 * fix for Makefile simplification * r.futures: Simplify Makefile to build all subdirs
landam
pushed a commit
to landam/grass-addons
that referenced
this pull request
Dec 10, 2020
* Simplify Makefile to build all subdirs * Filter out subdirs containing DEPRECATED file * Filter out subdirs containing DEPRECATED file * Apply to other Makefiles * Replaced by r.out.gdal * Replaced by r.out.gdal * Replaced by r.in.gdal/r.import * Simplify misc Makefile accordingly * Further clean raster Makefile
landam
pushed a commit
to landam/grass-addons
that referenced
this pull request
Dec 10, 2020
* Simplify Makefile to build all i.sentinel subdirs Approach following OSGeo#30 * fix for Makefile simplification * r.futures: Simplify Makefile to build all subdirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test this modified example Makefile for raster addons in GRASS 7.
After the modification, all subdirs are listed and thus build by default, so addon-devs do not have to add new modules manually (and deleted / moved addons do not have to be removed from the Makefile). If it is an acceptable solution, Makefiles for vector imagery and so on can be adjusted accordingly.
It would however probably require to find a solution for "deprecated" addons.
Not sure if it works with all versions of make...
See: https://trac.osgeo.org/grass/ticket/3901