Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page title: remove the page title section and the breadcrums #333

Merged
merged 3 commits into from
Sep 25, 2022

Conversation

nobeeakon
Copy link
Collaborator

What

Removed the page title section and the breadcrums

imagen

Why

Title + breadcrums (that text of /home/news) use a lot of vertical space, which makes the content be a bit hidden below it and the information those two elements show may not be adding much.

  • Page title:
    • Most pages have the title within the content. For example: news, manuals, etc. So it ends up being redundant and takes a lot of vertical space.
  • Breadcrums:
    • There is not much nesting in the site (like home/learn/manuals/manuals1/manuals2/...), so may not be add much. And also not many different options at the each url level, for example, learn/manuals doesn't group many different subroutes, and same applies for the other pages.
    • Think that primary navigation (menu + links) works just fine.
    • Some breadcrums look more like urls than breadcrums. For example in news the breadcrum says: home/news/2022_06_05_results_student_grant_caitlin , which is not ideal for users

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title: I agree. They don't add much. ...except confusion sometimes since sometimes they don't fit with the first heading.

Breadcrumbs: Given how they work now (URL-like pieces, sometimes not clickable), they take space (although not much).

Diff: Only removes code, that's fine with me.

@veroandreo
Copy link
Contributor

For me it's a +0 as I liked the aesthetics of the green title over the light green background... I won't block the merge though

@nobeeakon
Copy link
Collaborator Author

For me it's a +0 as I liked the aesthetics of the green title over the light green background... I won't block the merge though

it's also about the space usage, for example on mobile you loose around 16% of the view in unnecessary information

@neteler
Copy link
Member

neteler commented Sep 15, 2022

Just for illustration, some larger screenshots:

Currently on server:
image

After this PR:
image

@neteler neteler merged commit b3dfd68 into OSGeo:master Sep 25, 2022
@neteler
Copy link
Member

neteler commented Sep 25, 2022

Thanks!

@nobeeakon nobeeakon deleted the pageTitle branch September 26, 2022 13:49
@neteler neteler changed the title Page title Page title: remove the page title section and the breadcrums Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants