feature: seach in menu navbar #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it locally, looks nice! Doing so, I discovered severe SEO issues (see #335 for Google indexing, other search engines will have similar troubles). |
|
Looks cool to me, and seems to work fine :) Any further work here or it can be merged right away? |
not from my side @veroandreo , unless some bugs or something comes up |
neteler
approved these changes
Sep 15, 2022
|
I take liberty to merge this PR, thanks for your work, @nobeeakon ! |
This was referenced Sep 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Search feature. Uses duckduck go.
Not in focus
When focusing the icon (for example when the user clicks on the search icon)
Related to
Issue #19 . Further discussion on implementation alternatives there