Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI datacatalog: merge LocationMapTree and DataCatalogTree #740

Closed
petrasovaa opened this issue Jun 28, 2020 · 0 comments · Fixed by #755
Closed

wxGUI datacatalog: merge LocationMapTree and DataCatalogTree #740

petrasovaa opened this issue Jun 28, 2020 · 0 comments · Fixed by #755
Labels
enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
New GUI Startup

Comments

@petrasovaa
Copy link
Contributor

Currently DataCatalogTree inherits from LocationMapTree. This was done to reuse LocationMapTree in addon wx.metadata, however at this point it's not used there, there is an old copy of LocationMapTree. Since the distinction between the 2 classes seems little arbitrary, I suggest to merge them into DataCatalogTree. If this class is to be reused one day in wx.metadata, then it could be configured to turn on/off some functionality, but let's not use inheritance.

The change should be pretty simple, just merge constructors and remove all the functions with NotImplementedError.
@petrasovaa petrasovaa added enhancement New feature or request GUI wxGUI related gsoc Reserved for Google Summer of Code student(s) labels Jun 28, 2020
@wenzeslaus wenzeslaus added this to To do in New GUI Startup via automation Jul 1, 2020
@petrasovaa petrasovaa linked a pull request Jul 1, 2020 that will close this issue
wxGUI datacatalog: merge LocationMapTree and DataCatalogTree #755
Merged
New GUI Startup automation moved this from To do to Done Jul 2, 2020
petrasovaa pushed a commit that referenced this issue Jul 2, 2020
@lindakarlovska
wxGUI datacatalog: merged LocationMapTree and DataCatalogTree (#755)
9c8cfdc 
Into new class DataCatalogTree inheriting from TreeView. See #740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
No open projects
New GUI Startup
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wxGUI datacatalog: merge LocationMapTree and DataCatalogTree lindakarlovska/grass
1 participant
@petrasovaa