Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] wxGUI datacatalog: Add multiple GRASS databases #741

Closed
petrasovaa opened this issue Jun 28, 2020 · 3 comments · Fixed by #761
Closed

[Feat] wxGUI datacatalog: Add multiple GRASS databases #741

petrasovaa opened this issue Jun 28, 2020 · 3 comments · Fixed by #761
Labels
enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related

Comments

@petrasovaa
Copy link
Contributor

petrasovaa commented Jun 28, 2020

Currently, only the current database is in the GUI datacatalog. To make this more useful, user needs to be able to add additional ones.

Changes throughout the tree.py will be needed, starting e.g. with _initVariables, DefineItems. Next, wherever there is gisenv()['GISDBASE'] it needs to be checked if it should be replaced by currently selected db instead. But pretty much all methods need to be reviewed if any change is needed there.

As a way to test it, I suggest adding a button to the toolbar that would open a file dialog to add a new db.

For this issue, we don't need to implement any functionality on right click for db, later we would add e.g. add new location, remove from tree.

@petrasovaa petrasovaa added enhancement New feature or request GUI wxGUI related gsoc Reserved for Google Summer of Code student(s) labels Jun 28, 2020
@wenzeslaus wenzeslaus added this to To do in New GUI Startup via automation Jul 1, 2020
@petrasovaa petrasovaa linked a pull request Jul 3, 2020 that will close this issue
@petrasovaa petrasovaa moved this from To do to In progress in New GUI Startup Jul 11, 2020
New GUI Startup automation moved this from In progress to Done Jul 13, 2020
@mlennert
Copy link
Contributor

For this issue, we don't need to implement any functionality on right click for db, later we would add e.g. add new location, remove from tree.

Should another issue be opened for this or is there already one that I overlooked ? As soon as I tested adding a new database, I was looking for the option to remove it from the tree ?

@mlennert
Copy link
Contributor

For this issue, we don't need to implement any functionality on right click for db, later we would add e.g. add new location, remove from tree.

Should another issue be opened for this or is there already one that I overlooked ? As soon as I tested adding a new database, I was looking for the option to remove it from the tree ?

I see #747 addresses the first, but there is nothing for the latter, or ?

@petrasovaa
Copy link
Contributor Author

We will add a new one, it could be addressed together with more general managing of dbs in settings (so that they are remembered next time gui starts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants