Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] An action should be required before modifying other mapsets #843

Closed
wenzeslaus opened this issue Jul 28, 2020 · 0 comments · Fixed by #848
Closed

[Feat] An action should be required before modifying other mapsets #843

wenzeslaus opened this issue Jul 28, 2020 · 0 comments · Fixed by #848
Labels
enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related

Comments

@wenzeslaus
Copy link
Member

Is your feature request related to a problem? Please describe.

This is actually something in bitween a feature request and a bug report. GRASS GIS protects user's data against various mistakes by allowing any kinds of changes only in a current mapset. The Data tab should follow that.

Describe the solution you'd like

The Data tab should allow renaming and deleting other mapsets or locations only when the "allow editing" mode is on. This already applies to maps.

Describe alternatives you've considered

Creating new mapsets and locations is also editing other mapsets or locations. For examples, moving or copying maps to other mapsets is not allowed. However, I think this should be enabled even with "allowed editing" off for one theoretical and one practical reason: 1) Existing mapset is a GRASS entity which should oblige with the consistency rules and there may be an active session in the mapset. However, this does not apply when the mapset (or location) is being created. 2) For the first-time user use case, creating a new location is something we want user to do as smoothly as possible and having to allow editing first doesn't see intuitive.

Alternatively, the context menu item can be always enabled, but then it would ask whether or not to turn the "allow editing" mode on. However, this should be probably the same for maps too, so really this is a separate issue.

Additional context

This was discussed on Next steps in GSoC and beyond video call, July 15, 2020 (notes).

@wenzeslaus wenzeslaus added enhancement New feature or request GUI wxGUI related gsoc Reserved for Google Summer of Code student(s) labels Jul 28, 2020
@wenzeslaus wenzeslaus added this to To do in New GUI Startup via automation Jul 28, 2020
@wenzeslaus wenzeslaus changed the title [Feat] An action shoud be required before modifying other mapsets [Feat] An action should be required before modifying other mapsets Jul 28, 2020
@wenzeslaus wenzeslaus moved this from To do to Issues in progress in New GUI Startup Jul 30, 2020
New GUI Startup automation moved this from Issues in progress to Done Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant