Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Misleading lock symbol icon in the in the Data tab toolbar #844

Closed
wenzeslaus opened this issue Jul 28, 2020 · 0 comments · Fixed by #870
Closed

[Bug] Misleading lock symbol icon in the in the Data tab toolbar #844

wenzeslaus opened this issue Jul 28, 2020 · 0 comments · Fixed by #870
Labels
bug Something isn't working gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
New GUI Startup

Comments

@wenzeslaus
Copy link
Member

Describe the bug

The toolbar of Data tab uses lock/unlock symbol for allowing and disallowing edits in mapsets other than the current one. However, the locking refers to something else in GRASS GIS and that it locking of mapsets by a GRASS GIS process/session. That terminology is actually in line with other software where a file is locked when used by another process or instance of the same program.

Expected behavior

A new icon is needed. It may have the allowed and restricted states like now or it could be just one symbol relying on the toggle state of the button to convey the change of state. A common icon for editing in GIS, including GRASS GIS, is a pen/pencil, so that's at least a good starting point.
@wenzeslaus wenzeslaus added bug Something isn't working GUI wxGUI related gsoc Reserved for Google Summer of Code student(s) labels Jul 28, 2020
@wenzeslaus wenzeslaus added this to To do in New GUI Startup via automation Jul 28, 2020
@petrasovaa petrasovaa linked a pull request Aug 7, 2020 that will close this issue
Misleading lock symbol icon in the in the Data tab toolbar #870
Merged
@petrasovaa petrasovaa moved this from To do to Issues in progress in New GUI Startup Aug 8, 2020
New GUI Startup automation moved this from Issues in progress to Done Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
No open projects
New GUI Startup
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misleading lock symbol icon in the in the Data tab toolbar lindakarlovska/grass
1 participant
@wenzeslaus