Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable module check since svn keywords are not maintained by git #117

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

landam
Copy link
Member

@landam landam commented Sep 2, 2019

Module check is currently broken (see attached screenshot) since svn keywords are not maintained by git. This PR temporary disables this check. It can be re-enabled when svn keywords issue will be solved.

r-hants

@landam
Copy link
Member Author

landam commented Sep 2, 2019

Important to merge into relbr 7.6 and 7.8 before new releases (7.6.2 & 7.8.0).

@landam landam requested a review from neteler September 2, 2019 21:03
@landam landam added backport_needed bug Something isn't working labels Sep 2, 2019
@neteler
Copy link
Member

neteler commented Sep 2, 2019

Related ticket: https://trac.osgeo.org/grass/ticket/3880

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we find a better solution, I'd suggest to comment the version test based on SVN rev tag

@neteler
Copy link
Member

neteler commented Jan 10, 2020

This was reverted in

I am not convinced that it should be reverted. Rationale:

#define GIS_H_VERSION "$Revision$"
is no longer expanded and in the last many months we didn't find a git equivalent.

neteler added a commit that referenced this pull request Jan 11, 2020
* docker alpine: removed gisinit revision workaround

gisinit revision patch in #278 obsoleted by ec9b6f2

See: https://trac.osgeo.org/grass/ticket/3880

(also improves #117)
neteler added a commit that referenced this pull request Jan 11, 2020
* docker alpine: removed gisinit revision workaround

gisinit revision patch in #278 obsoleted by ec9b6f2

See: https://trac.osgeo.org/grass/ticket/3880

(also improves #117)
@neteler
Copy link
Member

neteler commented Jan 11, 2020

Finally addressed in ec9b6f2 (and backports)

landam pushed a commit to landam/grass that referenced this pull request Jan 28, 2020
landam pushed a commit to landam/grass that referenced this pull request Jan 28, 2020
* docker alpine: removed gisinit revision workaround

gisinit revision patch in OSGeo#278 obsoleted by ec9b6f2

See: https://trac.osgeo.org/grass/ticket/3880

(also improves OSGeo#117)
petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Feb 18, 2020
petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Feb 18, 2020
* docker alpine: removed gisinit revision workaround

gisinit revision patch in OSGeo#278 obsoleted by ec9b6f2

See: https://trac.osgeo.org/grass/ticket/3880

(also improves OSGeo#117)
@neteler neteler added this to the 7.8.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants