Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: NewIdRef was added only in wxPython 4.0.3. Fix import for <4.0.3 #155

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

marisn
Copy link
Contributor

@marisn marisn commented Oct 16, 2019

b5b00f9 breaks GUI for wxPython (4.0.0, 4.0.3] as NewIdRef was added only in wxPyhton 4.0.3.
Ref: https://wxpython.org/news/wxpython-4.0.3-release/index.html

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@neteler neteler changed the title wxGUI: NewIdRef was added only in wxPyhton 4.0.3. Fix import for <4.0.3 wxGUI: NewIdRef was added only in wxPyton 4.0.3. Fix import for <4.0.3 Oct 18, 2019
@neteler neteler changed the title wxGUI: NewIdRef was added only in wxPyton 4.0.3. Fix import for <4.0.3 wxGUI: NewIdRef was added only in wxPython 4.0.3. Fix import for <4.0.3 Oct 18, 2019
@neteler neteler merged commit 481e97b into OSGeo:master Oct 18, 2019
@marisn marisn deleted the fix_NewIdRef_import branch November 10, 2019 09:24
@neteler
Copy link
Member

neteler commented Nov 14, 2019

ok the backport to relbranch78 was missing:

now done in b7fb30a

petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Dec 3, 2019
landam pushed a commit to landam/grass that referenced this pull request Jan 28, 2020
@neteler neteler added this to the 7.8.1 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants