wxGUI: Split widget initialization from notebook logic #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
requested changes
May 25, 2021
gui/wxpython/lmgr/frame.py
Outdated
| @@ -149,7 +149,9 @@ def show_menu_errors(messages): | |||
| # create widgets | |||
| self._createMenuBar() | |||
| self.statusbar = self.CreateStatusBar(number=1) | |||
| self.notebook = self._createNoteBook() | |||
| notebook = self._createNotebook() | |||
| self._createWidgets(notebook) | |||
There was a problem hiding this comment.
Unless createWidgets is used also elesewhere, I think it's unnecessary function, I would just put there its content directly, it will be more readable.
gui/wxpython/lmgr/frame.py
Outdated
| self.notebook = self._createNoteBook() | ||
| notebook = self._createNotebook() | ||
| self._createWidgets(notebook) | ||
| self.notebook = self._addPagesToNotebook(notebook) |
There was a problem hiding this comment.
This function probably shouldn't return the notebook.
gui/wxpython/lmgr/frame.py
Outdated
Comment on lines
426
to
430
| self._createDataCatalogWidget(parent) | ||
| self._createDisplayWidget(parent) | ||
| self._createSearchModuleWidget(parent) | ||
| self._createConsoleWidget(parent) | ||
| self._createPythonShellWidget(parent) |
There was a problem hiding this comment.
The work widget seems to be redundant in the function names.
petrasovaa
approved these changes
May 30, 2021
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits widget initialization (data catalog, display etc.) from notebook logic. Makes smaller methods for each widget creation.