wxGUI: refactoring: build display status bar based on wx.StatusBar widget #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindakarlovska
added
GUI
added 3 commits
June 15, 2021 10:49
petrasovaa
requested changes
Jun 16, 2021
There was a problem hiding this comment.
When you right click on map display and select Hide statusbar, it's not working because the pane itself is not hidden. Currently the hiding/showing is in SbManager, but it may be better to keep SbManager for managing the content and the hiding/showing could be done by the frame directly (it knows about the pane unlike the SbManager). So create ShowStatusbar and IsStatusbarShown functions in MapFrame that show/hide the pane.
|
@petrasovaa Not sure why there are these slant stripes now: I first thought it is something related to the pane resizing but it looks more like related to the whole frame... (it disappears when Map Window is maximized). I noticed we have the same stripes in the bottom of the mainframe window as well. Do you have any suggestion about that? Otherwise, the appearance is the same as originally was. |
petrasovaa
requested changes
Jun 16, 2021
I noticed it but I am not sure either. It's probably ok. |
petrasovaa
approved these changes
Jun 16, 2021
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 16, 2021
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2021
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2021
* develop: wxGUI/map display: manage wx.StatusBar widget by AUI (OSGeo#1646)
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jun 19, 2021
Needed for single layout, map display will not be always a wx.frame
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
Needed for single layout, map display will not be always a wx.frame
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
May 9, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
May 9, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
May 21, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
May 21, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 3, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 3, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 27, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 27, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 2, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 2, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 10, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 10, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 31, 2024
Needed for single layout, map display will not be always a wx.frame
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 31, 2024
Needed for single layout, map display will not be always a wx.frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigning the form of display map status bar implementation.
It was originally created directly using CreateStatusBar function, which is, however, directly connected to the wx.Frame widget.
For further implementation of the SingleLayout, we need to replace MapFrame widget by MapPanel widget.
MapPanel widget does not support CreateStatusBar function.
Reimplemented status bar in a Map Display for a better context:
Original status bar:
