-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter: Non-interactive display #1668
Conversation
…grass into non-interactive-display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! The difference to the example_notebook.ipynb is huge, but we need resolve couple of things before this is a full replacement. Please, specify in the PR description what you now see as a goal for this PR (you can change that any time later as we discuss things further).
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is couple more things about handling of the rendering environment. Basically, it's: see GrassRenderer here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and it is ready to be tested!
* Non-interactive display functions with rendering based on d-commands. * Rendering encapsulated in a class. Each object holds unique settings. * Examples in notebook are now showing this new API. * Deleted display_settings function. * Rendering class init accepts env parameter as all well-behaved functions in grass.script. * grass.script is used as a backend for running commands. * Rendering run method provides general way of rendering with any d-command (which is not monitor-focused). * Errors reported as exceptions, e.g., ValueError. * Added pathlib Path object supported for filenames.
* Non-interactive display functions with rendering based on d-commands. * Rendering encapsulated in a class. Each object holds unique settings. * Examples in notebook are now showing this new API. * Deleted display_settings function. * Rendering class init accepts env parameter as all well-behaved functions in grass.script. * grass.script is used as a backend for running commands. * Rendering run method provides general way of rendering with any d-command (which is not monitor-focused). * Errors reported as exceptions, e.g., ValueError. * Added pathlib Path object supported for filenames.
This is a set of functions to display non-interactive maps in Jupyter Notebooks, as proposed in the Google Summer of Code project, Improved Integration of GRASS and Jupyter Notebooks. The goal of these functions is to make the display of GRASS maps more intuitive in Jupyter Notebooks. You can test the functionality by launching the repository in Binder here:
https://mybinder.org/v2/gh/chaedri/grass/non-interactive-display?urlpath=lab%2Ftree%2Fdoc%2Fnotebooks%2Fjupyter_integration.ipynb