wxGUI: Remove python2 specific sys.stderr encoding handling. Fixes #3921 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This new bug is quite annoying, and it affects also GRASS 7.8. I suggest to merge and backport to 7.8. |
|
We need to create 7.8.1RC2 including this fix asap. |
petrasovaa
approved these changes
Nov 1, 2019
neteler
pushed a commit
that referenced
this pull request
Nov 3, 2019
|
Backported to relbranch78 in 657ef28 |
petrasovaa
pushed a commit
to petrasovaa/grass
that referenced
this pull request
Dec 3, 2019
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual cause of #3921 is printing to stderr: "sys stderr: write() argument must be str, not bytes", although passed error message is str. Removing this python2 specific workaround fixes the issue.