wxGUI/splashscreen: use standard one, try to show it before main app, increase timeout #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… increase timeout
tmszi
approved these changes
Jul 12, 2021
|
Awesome, thanks! |
|
@lindakladivova, as part of this I am removing the commented test code in wxgui.py, it shouldn't go into release. |
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jul 12, 2021
… increase timeout (OSGeo#1718) * remove testing code
petrasovaa
added a commit
that referenced
this pull request
Dec 14, 2021
… increase timeout (#1718) * remove testing code
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
… increase timeout (OSGeo#1718) * remove testing code
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
… increase timeout (OSGeo#1718) * remove testing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the splash screen shows up only after the main application shows up, at least on Ubuntu. This attempts to start showing it before the application.
Ideally, it would be good to test on Windows/Mac, if there is any difference in behavior, but we can also just merge it and test then.