wxGUI: Single-Window GUI: Integrate new map display wx.Panels into a AuiNotebook center pane #1735 #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notebook tabs - base working suggestion, probably will be needed to make some general methods like GetRelatedLmgrPage etc. (GetCurrentPage is not sufficient)
lindakarlovska
added
GUI
lindakarlovska
changed the title
added 2 commits
July 21, 2021 19:19
…d, new GetMapDisplayIndex method created
petrasovaa
approved these changes
Jul 22, 2021
gui/wxpython/main_window/frame.py
Outdated
Comment on lines
313
to
320
| arts = [ | ||
| aui.AuiDefaultTabArt, | ||
| aui.AuiSimpleTabArt, | ||
| aui.VC71TabArt, | ||
| aui.FF2TabArt, | ||
| aui.VC8TabArt, | ||
| aui.ChromeTabArt, | ||
| ] |
There was a problem hiding this comment.
Let's just pick one here and set it directly.
There was a problem hiding this comment.
Ok. I have chosen aui.AuiDefaultTabArt() (https://docs.wxpython.org/wx.lib.agw.aui.tabart.AuiDefaultTabArt.html#wx.lib.agw.aui.tabart.AuiDefaultTabArt)
gui/wxpython/main_window/frame.py
Outdated
|
|
||
| # make a new page in the bookcontrol for the layer tree (on page 0 of | ||
| # the notebook) | ||
| self.pg_panel = wx.Panel(self.notebookLayers, id=wx.ID_ANY, style=wx.EXPAND) |
There was a problem hiding this comment.
style=wx.EXPAND doesn't look correct to me, is that in the documentation somewhere?
…pears), style for display panel corrected, one ArtProvider for mapnotebook chosen
petrasovaa
reviewed
Jul 29, 2021
Closed
7 tasks
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
…AuiNotebook center pane OSGeo#1735 (OSGeo#1732)
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
…AuiNotebook center pane OSGeo#1735 (OSGeo#1732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up the changes that are about to be merged - #1729, #1689, #1675.
So far, it is based on my local merged branch which already knows these changes. But I think even without the mentor's testing it makes sense to start working on this as later we can rebase it.
This PR aims at the basic integration of the new Map Display into the center AuiNotebook pane. Apart from this integration, it repairs existing event handlers and methods. It does not add any new ones.
As we have basically several small things for coding, I have eventually decided to solve them in this one PR. Some of them require changing of one, two rows, so it probably does not make sense to have more than one PR.
Tasks are as follow:
Remove methods related to the depreciated Map Display wx.Frame.
Fix behaviour when adding or switching to a new location (now it does not close previously opened map displays)
Make a newly added AuiNotebook tab active when adding a new Display tab.
Edit an existing closing event for the Display tab. This event should close the related AuiNotebook tab.
Edit an existing event for the switching between Display tabs. This event should make the related AuiNotebook tab active.
Fix an existing RenameDisplay event handler.
Fix adding and removing of the 3D View pane. Decide where should this tab go when launching 3D for the first time.