Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winGRASS: change form BU Execute to "GenericRead + GenericExecute" #2068

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

dnewcomb
Copy link
Contributor

@dnewcomb dnewcomb commented Jan 5, 2022

This PR changes Line 761 of of the nsis installer template in the mswindows directory, GRASS-installer.nsi.tmpl from using "BU" "Execute" to using the language - independent ""(s-1-5-32-545)" "GenericRead + GenericExecute"
Should fix issue identified in #1965 . Fix based off information at https://peter.bloomfield.online/nsis-access-control-problem-with-built-in-users-group/ , where the BU permissions option does not work on installations of a different language than the language the NSIS installer was created on Windows version 8 and above computers.

…te to S-1-5-32-545 Generic User Read and Generic User Execute
Copy link
Member

@hellik hellik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hellik
Copy link
Member

hellik commented Jan 5, 2022

@neteler will there another release in the 7.8.x line? If yes, then this needs to be backported

@hellik hellik requested review from landam and ninsbl January 5, 2022 05:12
@neteler neteler changed the title edit of line 761 in GRASS-Installer.nsi.tmpl to change form BU Execu… winGRASS: change form BU Execute to "GenericRead + GenericExecute" Jan 5, 2022
@neteler neteler added this to the 7.8.7 milestone Jan 5, 2022
@neteler neteler added backport_needed windows Microsoft Windows specific labels Jan 5, 2022
@neteler
Copy link
Member

neteler commented Jan 5, 2022

@dnewcomb please use a short meaningful PR title, as it is used for the ChangeLog (feel free to modify my title suggestion above). Thanks.

@neteler
Copy link
Member

neteler commented Jan 5, 2022

@neteler will there another release in the 7.8.x line? If yes, then this needs to be backported

It also needs to be forward-ported as this PR is currently against relbranch80.

@hellik
Copy link
Member

hellik commented Jan 5, 2022

New title is fine.

@neteler neteler mentioned this pull request Jan 5, 2022
@hellik
Copy link
Member

hellik commented Jan 5, 2022

@neteler will there another release in the 7.8.x line? If yes, then this needs to be backported

It also needs to be forward-ported as this PR is currently against relbranch80.

I merge now this PR via the gh website.

as I don't have my dev/build environment at hand here at the moment, @neteler may I ask you to backport and forward-port this PR? thanks.

@hellik hellik merged commit 04af08c into OSGeo:releasebranch_8_0 Jan 5, 2022
@neteler
Copy link
Member

neteler commented Jan 5, 2022

We need a new PR to get this into main:

git push upstream main 
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 12 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 568 bytes | 568.00 KiB/s, done.
Total 4 (delta 3), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: 2 of 2 required status checks are expected.
To github.com:OSGeo/grass.git
 ! [remote rejected]     main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:OSGeo/grass.git'

(note: please generally submit PRs against main - backporting is easier.)

neteler pushed a commit that referenced this pull request Jan 5, 2022
…te to S-1-5-32-545 Generic User Read and Generic User Execute (#2068)

winGRASS start enabled now also for normal users in Windows OS.
@neteler
Copy link
Member

neteler commented Jan 5, 2022

We need a new PR to get this into main:

... done in #2069.

(note: please generally submit PRs against main - backporting is easier.)

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants