-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winGRASS: change form BU Execute to "GenericRead + GenericExecute" #2068
Conversation
…te to S-1-5-32-545 Generic User Read and Generic User Execute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
@neteler will there another release in the 7.8.x line? If yes, then this needs to be backported |
It also needs to be forward-ported as this PR is currently against relbranch80. |
|
New title is fine. |
I merge now this PR via the gh website. as I don't have my dev/build environment at hand here at the moment, @neteler may I ask you to backport and forward-port this PR? thanks. |
|
We need a new PR to get this into (note: please generally submit PRs against |
…te to S-1-5-32-545 Generic User Read and Generic User Execute (#2068) winGRASS start enabled now also for normal users in Windows OS.
... done in #2069.
|
This PR changes Line 761 of of the nsis installer template in the mswindows directory, GRASS-installer.nsi.tmpl from using "BU" "Execute" to using the language - independent ""(s-1-5-32-545)" "GenericRead + GenericExecute"
Should fix issue identified in #1965 . Fix based off information at https://peter.bloomfield.online/nsis-access-control-problem-with-built-in-users-group/ , where the BU permissions option does not work on installations of a different language than the language the NSIS installer was created on Windows version 8 and above computers.