-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Version Numbering #2357
RFC: Version Numbering #2357
Conversation
|
Thanks @neteler for the comments. The minor versus micro is clearly an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO ready for PSC voting which should happen before the upcoming 8.3.0 release.
|
I identified some todos, but perhaps they are for next version of the RFC document:
|
|
Perhaps discussion in #2575 is an opportunity to reflect again on what versioning and branching scheme we want to adopt. Perhaps what is now major.minor is just major, i.e., branch is major, not major.minor, and we drop micro. |
|
The micro number has not been terribly relevant for some time. GRASS
generally does not do bug fix releases and address version at the same time.
I do like using odd minor numbers for development, but I think we could
release with major.minor and kill micro. I'm not sure just using major
would provide enough granularity between stable and unstable releases.
On 10/20/2022 6:01 PM, Vaclav Petras wrote:
Perhaps discussion in #2575
<#2575> is an opportunity to
reflect again on what versioning and branching scheme we want to
adopt. Perhaps what is now major.minor is just major, i.e., branch is
major, not major.minor, and we drop micro.
Message ID: ***@***.***>
--
Best Regards,
-Brad
|
20cd6b6
to
676996c
Compare
676996c
to
e2cd5ba
Compare
This PR is a RFC for a new version numbering system. The main point is not making any distinction between even and odd version numbers. After 8.2, 8.3 would follow.
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
…and mention of builds not being tags.
7462a4a
to
779681a
Compare
|
I also implemented the minimal changes required by this RFC. Updating version numbers on main is now the same as on release branch, so the script which was capturing the intricacies of even-odd version distinction is now simpler. As a consequence, the version on the main branch will no longer be in format X.Y.dev and X.Ydev, but always X.Y.Zdev like the release branches. In other words, with this RFC, there is no distinction between even and odd in terms of meaning and there is no distinction in numbering of different branches. The main branch is simply the upcoming release and the (non-described) branching procedure updates only the version on main, while the branch keeps the original version from main. (Currently both need to be updated.) The above is a example how this RFC simplifies the branching and release procedure which is an important aspect of this RFC. The RFC suggests an additional change to the dev labeling (among other things), X.Y.Zdev should become X.Y.Z-dev because that's Semantic Versioning. However, I suggest to implement that separately, perhaps after branching or releasing 8.3. |
|
I guess a number is needed for this RFC. How does that work? |
|
If accepted as is, it fixes #2335. |
|
Nice addition, +1. (by the way, here was my own definition of versioning, for the MapServer users : https://github.com/MapServer/MapServer/blob/main/SECURITY.md#version-numbering-explained ) |
|
As soon as the PSC adopts this RFC (voting is ongoing in https://lists.osgeo.org/pipermail/grass-psc/), the state will be changed to "Approved". |
In May, several people agreed to merge the finalized RFC in OSGeo#2357 before it was adopted in a face-to-face meeting. In the meantime, the RFC was adopted. This updates the status. Adoption email: https://lists.osgeo.org/pipermail/grass-psc/2023-June/002724.html
In May, several people agreed to merge the finalized RFC in #2357 before it was adopted in a face-to-face meeting. In the meantime, the RFC was adopted. This updates the status. Adoption email: https://lists.osgeo.org/pipermail/grass-psc/2023-June/002724.html
In May, several people agreed to merge the finalized RFC in #2357 before it was adopted in a face-to-face meeting. In the meantime, the RFC was adopted. This updates the status. Adoption email: https://lists.osgeo.org/pipermail/grass-psc/2023-June/002724.html
In May, several people agreed to merge the finalized RFC in OSGeo#2357 before it was adopted in a face-to-face meeting. In the meantime, the RFC was adopted. This updates the status. Adoption email: https://lists.osgeo.org/pipermail/grass-psc/2023-June/002724.html
This PR is a RFC for a new version numbering system. The main point is not making any distinction between even and odd version numbers. After 8.2, 8.3 would follow.
In May, several people agreed to merge the finalized RFC in OSGeo#2357 before it was adopted in a face-to-face meeting. In the meantime, the RFC was adopted. This updates the status. Adoption email: https://lists.osgeo.org/pipermail/grass-psc/2023-June/002724.html
This PR is a RFC for a new version numbering system. The main point is not making any distinction between even and odd version numbers. After 8.2.z, 8.3.0 would follow.
Notably, this RFC does not follow the current RFC procedure (if any), but creates a PR as suggested in the past as a possible improvement of the procedure.
Closes #2335.