Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: set window offset (OS panel) for single/multiple window mode #2417

Merged
merged 1 commit into from
Oct 9, 2022
Merged

wxGUI: set window offset (OS panel) for single/multiple window mode #2417

merged 1 commit into from
Oct 9, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jun 6, 2022

Fixes #2415.

@tmszi tmszi added bug Something isn't working windows Microsoft Windows specific GUI wxGUI related macOS macOS specific backport_needed labels Jun 6, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jun 6, 2022
@nilason
Copy link
Contributor

nilason commented Jun 6, 2022

Great initiative @tmszi ! At the moment I have limited time to test this.
I was initially thinking of a solution for a default of something like:

  1. Set window size of about 60-80 % of display size
  2. And Centre() the window (or even better: horizontally centred and ~1/3 from top)
  3. Then save any eventual later changes of position.

Please give me some time to test, maybe your suggested changes will work just fine.

@tmszi
Copy link
Member Author

tmszi commented Oct 5, 2022

Please give me some time to test, maybe your suggested changes will work just fine.

Could @nilason test this PR, please? Thanks. It would be good move forward with this PR.

nilason
nilason approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and I appreciate your patience.

This works fine with my tests. Thanks @tmszi !

@tmszi tmszi merged commit 822ceb8 into OSGeo:main Oct 9, 2022
tmszi added a commit that referenced this pull request Oct 9, 2022
@tmszi
wxGUI: set window offset (OS panel) for single/multiple window mode (#…
2326810 
…2417)
@tmszi tmszi deleted the wxgui_fix_single_multiple_window_mode_offset_pos branch October 9, 2022 03:19
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@tmszi @ninsbl
wxGUI: set window offset (OS panel) for single/multiple window mode (O…
6068248 
…SGeo#2417)
@nilason nilason mentioned this pull request Oct 27, 2022
Closed
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@tmszi @ninsbl
wxGUI: set window offset (OS panel) for single/multiple window mode (O…
46e759f 
…SGeo#2417)
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
@tmszi @marisn
wxGUI: set window offset (OS panel) for single/multiple window mode (O…
7bae561 
…SGeo#2417)
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@tmszi @neteler
wxGUI: set window offset (OS panel) for single/multiple window mode (O…
e5c7cf2 
…SGeo#2417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilason nilason nilason approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GUI wxGUI related macOS macOS specific windows Microsoft Windows specific
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

[Bug] Main GUI window bad placed on Mac
2 participants
@tmszi @nilason