-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/psmap: remove loading EPS file via using Ghostscript image rendering on OS MS Windows platform #2419
Merged
tmszi
merged 3 commits into
OSGeo:main
from
tmszi:wxgui_psmap_fix_make_preview_on_os_ms_win
Jun 8, 2022
Merged
wxGUI/psmap: remove loading EPS file via using Ghostscript image rendering on OS MS Windows platform #2419
tmszi
merged 3 commits into
OSGeo:main
from
tmszi:wxgui_psmap_fix_make_preview_on_os_ms_win
Jun 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ering on OS MS Windows platform PIL module has ability to load EPS file directly on this platform.
petrasovaa
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great the workaround is not needed any more, thank you for fixing it.
tmszi
added a commit
that referenced
this pull request
Jun 8, 2022
…ering on OS MS Windows platform (#2419) PIL module has ability to load EPS file directly on this platform.
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jun 8, 2022
…ering on OS MS Windows platform (OSGeo#2419) PIL module has ability to load EPS file directly on this platform.
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jun 10, 2022
…ering on OS MS Windows platform (OSGeo#2419) PIL module has ability to load EPS file directly on this platform.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
…ering on OS MS Windows platform (OSGeo#2419) PIL module has ability to load EPS file directly on this platform.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
…ering on OS MS Windows platform (OSGeo#2419) PIL module has ability to load EPS file directly on this platform.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
…ering on OS MS Windows platform (OSGeo#2419) PIL module has ability to load EPS file directly on this platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
wxGUI Cartographic Composer preview image doesn't rendered on OS MS Windows platform.
To Reproduce
Steps to reproduce the behavior:
g.gui.psmapExpected behavior
Preview image should be rendered as on other OS platforms.
System description:
Additional context
I tried to fix the error above, including a function
GhostscriptForWindowsgrass/gui/wxpython/psmap/utils.py
Line 471 in c7495e2