-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/psmap: Ghostscript HyperlinkDialog is needed #2441
Merged
tmszi
merged 3 commits into
OSGeo:main
from
tmszi:wxgui_psmap_revert_back_missing_gs_hyperlink_dlg
Jul 19, 2022
Merged
wxGUI/psmap: Ghostscript HyperlinkDialog is needed #2441
tmszi
merged 3 commits into
OSGeo:main
from
tmszi:wxgui_psmap_revert_back_missing_gs_hyperlink_dlg
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3a8d5d
to
2dc2565
Compare
|
Rebase 2dc2565. |
petrasovaa
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine!
gui/wxpython/psmap/frame.py
Outdated
| "You can donwload {program} {arch} version here." | ||
| ).format( | ||
| program=program, | ||
| arch="64bit" if "64" in program else "32Bit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| arch="64bit" if "64" in program else "32Bit", | |
| arch="64bit" if "64" in program else "32bit", |
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jul 19, 2022
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jul 19, 2022
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jul 19, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert back PR #2421.
Describe the bug
If Ghostscript program isn't available on the OS MS Windows, error is printed to the stdout.
To Reproduce
Steps to reproduce the behavior:
g.gui.psmapExpected behavior
Show Hyperlink dialog with correct label and hyperlink if Ghostscript program isn't available.
System description (please complete the following information):
Additional context
For reading EPS file, PIL require Ghostscript program to be installed.