Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps #2465

Merged
merged 1 commit into from
Jul 16, 2022
Merged

wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps #2465

merged 1 commit into from
Jul 16, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jun 25, 2022

Describe the bug
Deselecting all maps from Image create/edit group dialog is not working.

To Reproduce
Steps to reproduce the behavior:

  1. Launc wxGUI
  2. From the main window menu choose Imagery -> Develop images and groups -> Create/edit group
  3. Select some existed group e.g. nitrogen
  4. Check Select all checkbox widget
  5. Uncheck Select all checkbox widget
  6. See error
Traceback (most recent call last):
  File
"/usr/lib64/grass83/gui/wxpython/gui_core/dialogs.py", line
987, in OnGSelAll

self.gLayerBox.DeselectAll()
AttributeError
:
'ListBox' object has no attribute 'DeselectAll'

Expected behavior
Deselecting all maps from Image create/edit group dialog should be work without error.

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Jun 25, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jun 25, 2022
petrasovaa
petrasovaa approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tmszi tmszi merged commit fc15b10 into OSGeo:main Jul 16, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Jul 16, 2022
@tmszi
wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps (
eee2406 
OSGeo#2465)
tmszi added a commit to tmszi/grass that referenced this pull request Jul 16, 2022
@tmszi
wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps (
f120a69 
OSGeo#2465)
tmszi added a commit to tmszi/grass that referenced this pull request Jul 16, 2022
@tmszi
wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps (
71b20db 
OSGeo#2465)
@tmszi tmszi deleted the wxgui_listbox_add_deselectall_method branch July 16, 2022 16:14
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@tmszi @ninsbl
wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps (
6d5b0cf 
OSGeo#2465)
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@tmszi @ninsbl
wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps (
2174b7c 
OSGeo#2465)
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@tmszi @neteler
wxGUI/gui_core: fix imagery create/edit group dialog deselect all maps (
1026e12 
OSGeo#2465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmszi @petrasovaa