Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/psmap: don't set StatusBar widget text when frame is closed #2487

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jul 20, 2022

Describe the bug
When map preview is rendered and Cartographic Composer frame is closed, error message is printed.

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI Cartographic Composer g.gui.psmap
  2. From the toolbar activate Map frame tool and add raster map e.g. elevation
  3. From the toolbar hit Show preview tool
  4. From the toolbar hit Show preview tool again
  5. Close the Cartographic Composer window
  6. See error
Traceback (most recent call last):
  File "/home/tomas/.local/lib/python3.9/site-
packages/wx/core.py", line 2254, in Notify

self.notify()
  File "/home/tomas/.local/lib/python3.9/site-
packages/wx/core.py", line 3410, in Notify

self.result = self.callable(*self.args, **self.kwargs)
  File "/usr/lib64/grass83/gui/wxpython/psmap/frame.py",
line 517, in <lambda>

self.delayedCall = wx.CallLater(4000, lambda:
self.SetStatusText("", 0))
RuntimeError
:
wrapped C/C++ object of type PsMapFrame has been deleted

Expected behavior
When map preview is rendered and Cartographic Composer frame is closed, error message should not be printed.

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Jul 20, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jul 20, 2022
@tmszi tmszi merged commit 916dba1 into OSGeo:main Oct 25, 2022
@tmszi tmszi deleted the wxgui_psmap_fix_set_statusbar_text branch October 25, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants