grass.jupyter: fix bbox reprojection for InteractiveMap #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
requested changes
Jul 26, 2022
There was a problem hiding this comment.
The computation look good.
The failing pytest needs an update. The original function was returning strings, but the new one returns float which is better, more expected behavior. If needed, use pytest.approx.
| @@ -47,8 +45,12 @@ def reproject_region(region, from_proj, to_proj): | |||
| :return dict region: reprojected region as a dictionary with long key names | |||
| """ | |||
| region = region.copy() | |||
| # reproject all corners, otherwise reproj. region may be underestimated | |||
There was a problem hiding this comment.
Do you want to mention here the complete v.in.region based solution from r.import?
wenzeslaus
approved these changes
Jul 27, 2022
petrasovaa
added a commit
that referenced
this pull request
Jul 28, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Region in pseudo mercator tmp location could be smaller than it was supposed to because only 2 corners of the region were reprojected. Now it reprojects all 4 corners and gets maximum bbox from them.