Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/gui_core: fix Create or edit image group dialog Select all CheckBox widget for selecting all items #2514

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Aug 6, 2022

Describe the bug
When you check Select all CheckBox widget from Create or edit image group dialog all added raster maps aren't selected.

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI
  2. From the menu choose Imagery -> Develop images and groups -> Create/edit group
  3. From the Create or edit image group dialog hit Add button widget and add some raster maps
  4. From Create or edit image group dialog check Select all CheckBox widget
  5. Added raster maps are not selected

or

  1. From the Create or edit image group dialog Select existing group or enter name of new group ComboBox widget choose existed image group e.g. nitrogen.
  2. From the Create or edit image group dialog hit Add button widget and add some raster maps
  3. From Create or edit image group dialog check Select all CheckBox widget
  4. Only raster maps which is currently in nitrogen group are selected

Expected behavior
When you check Select all CheckBox widget from Create or edit image group dialog all added raster maps should be selected.

System description:

  • Operating System: all
  • GRASS GIS version: all

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Aug 6, 2022
@tmszi tmszi added this to the 8.2.1 milestone Aug 6, 2022
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but it makes sense.

@tmszi tmszi merged commit e417678 into OSGeo:main Oct 27, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Oct 27, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Oct 27, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Oct 27, 2022
@tmszi tmszi deleted the wxgui-fix-group_dialog-select-all-checkbox-widget branch October 27, 2022 03:43
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants