Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: add r.buildvrt module into DevelopRasterMap toolbox #2621

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Nov 2, 2022

Fixes #2620.

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Nov 2, 2022
@tmszi tmszi added this to the 8.2.1 milestone Nov 2, 2022
@tmszi tmszi requested a review from neteler November 4, 2022 08:21
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wenzeslaus
Copy link
Member

Adding to menu sounds good, but isn't there a better home for this? In which way it is overlay? Isn't this more some data management?

@tmszi
Copy link
Member Author

tmszi commented Nov 5, 2022

Adding to menu sounds good, but isn't there a better home for this? In which way it is overlay? Isn't this more some data management?

I wasn't sure, I was deciding between DevelopRasterMap and OverlayRasters toolbox. I decided that when I looked at the manual page, the section SEE ALSO which contains r.patch which are part of the OverlayRasters toolbox.

@petrasovaa
Copy link
Contributor

Adding to menu sounds good, but isn't there a better home for this? In which way it is overlay? Isn't this more some data management?

I wasn't sure, I was deciding between DevelopRasterMap and OverlayRasters toolbox. I decided that when I looked at the manual page, the section SEE ALSO which contains r.patch which are part of the OverlayRasters toolbox.

I think it should go under Develop Raster Map, after Tiling. It is doing a mosaic of tiles, so it's directly related to that. While r.patch can do a mosaic (and that's why it's linked from the man page), the reason why it's in Overlay rasters is its other usage - filling no data cells.

@tmszi tmszi changed the title wxGUI: add r.buildvrt module into OverlayRasters toolbox wxGUI: add r.buildvrt module into DevelopRasterMap toolbox Nov 7, 2022
@tmszi tmszi merged commit 5d64de2 into OSGeo:main Nov 7, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Nov 7, 2022
@tmszi tmszi deleted the add-r_buildvrt-into-wxgui-toolboxes branch November 7, 2022 06:07
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] r.buildvrt not visible in gui
4 participants