Do not install config.status #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it will contain the build hostname which makes it hard to reproduce. See https://reproducible-builds.org/ for why this matters.
|
I tried to remember why this was implemented but don't really find a trace. I'd say "fine for me"... |
|
Only based on what is in documentation for config.status, it does not seem useful for us right now and any future better compilations (cross-compiling or multiple compilations from the same source tree) will likely need to be done using CMake anyway. |
neteler
pushed a commit
that referenced
this pull request
Dec 23, 2019
Installed config.status will contain the build hostname which makes the build it hard to reproduce. This is useful for a reproducible builds.
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jan 28, 2020
Installed config.status will contain the build hostname which makes the build it hard to reproduce. This is useful for a reproducible builds.
petrasovaa
pushed a commit
to petrasovaa/grass
that referenced
this pull request
Feb 18, 2020
Installed config.status will contain the build hostname which makes the build it hard to reproduce. This is useful for a reproducible builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not install the
config.statusfilebecause it will contain the build hostname
which makes it hard to reproduce.
See https://reproducible-builds.org/ for why this matters.
Together with #251 and #247 this made the
grassopenSUSE package build reproducibly.This PR is probably the least important of the 3, because it can easily be implemented with a
rmin thegrass.specfile.This PR was done while working on reproducible builds for openSUSE.