Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install config.status #263

Merged
merged 1 commit into from Dec 20, 2019
Merged

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Dec 18, 2019

Do not install the config.status file
because it will contain the build hostname
which makes it hard to reproduce.

See https://reproducible-builds.org/ for why this matters.

Together with #251 and #247 this made the grass openSUSE package build reproducibly.
This PR is probably the least important of the 3, because it can easily be implemented with a rm in the grass.spec file.

This PR was done while working on reproducible builds for openSUSE.

because it will contain the build hostname
which makes it hard to reproduce.

See https://reproducible-builds.org/ for why this matters.
@neteler

This comment has been minimized.

Copy link
Member

neteler commented Dec 18, 2019

I tried to remember why this was implemented but don't really find a trace.
I suspect that the idea was to build GRASS GIS with cross-compiling from the same source tree (but still I wouldn't know why then copy over the file to the target directory).

I'd say "fine for me"...

@wenzeslaus

This comment has been minimized.

Copy link
Member

wenzeslaus commented Dec 20, 2019

Only based on what is in documentation for config.status, it does not seem useful for us right now and any future better compilations (cross-compiling or multiple compilations from the same source tree) will likely need to be done using CMake anyway.

@wenzeslaus wenzeslaus merged commit 86f0eca into OSGeo:master Dec 20, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@bmwiedemann bmwiedemann deleted the bmwiedemann:configstatus branch Dec 20, 2019
neteler pushed a commit that referenced this pull request Dec 23, 2019
Installed config.status will contain the build hostname
which makes the build it hard to reproduce.

This is useful for a reproducible builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.