lib/cdhc: remove Cdhc_enormp() #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It contains questionable code, is furthermore undocumented and unused.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
It contained questionable code, is furthermore undocumented and unused.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
It contained questionable code, is furthermore undocumented and unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cdhc lib function
Cdhc_enormp()contains questionable code, is furthermore undocumented and unused. This PR suggests to remove it from the source.The fact that the cdhc library's early history within GRASS predated the use of version control, makes it even more difficult to track its intended function and implementation.
This issue was unfolded in #2164.