Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.in.ogr: handle skipped, not empty columns #2658

Merged
merged 2 commits into from
Nov 20, 2022

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented Nov 17, 2022

There was a glitch in #2630 that values from skipped but not empty columns of unsupported data types were still tried to insert into the table in the GRASS DB.
This PR skips also to INSERT values from those columns, using the same logic as for the columns themself.

@ninsbl ninsbl added the bug Something isn't working label Nov 17, 2022
@ninsbl ninsbl added this to the 8.2.1 milestone Nov 17, 2022
@ninsbl ninsbl requested review from nilason and metzm November 17, 2022 22:36
@ninsbl ninsbl linked an issue Nov 18, 2022 that may be closed by this pull request
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, testing worked fine.

Just a small typo -> "skipped".

@ninsbl
Copy link
Member Author

ninsbl commented Nov 20, 2022

Looks good to me, testing worked fine.

Just a small typo -> "skipped".

Thanks for both checking and pointing out. Fixed now.

@ninsbl ninsbl merged commit 4aec398 into OSGeo:main Nov 20, 2022
ninsbl added a commit that referenced this pull request Nov 20, 2022
* handle skipped, not empty columns

* fix typo
ninsbl added a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* handle skipped, not empty columns

* fix typo
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
* handle skipped, not empty columns

* fix typo
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
* handle skipped, not empty columns

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] v.in.ogr: handle columns with unsupported datatype in GRASS DBMI
2 participants