Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add ClangFormat check #2716

Merged
merged 1 commit into from
Dec 23, 2022
Merged

CI: add ClangFormat check #2716

merged 1 commit into from
Dec 23, 2022

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Dec 21, 2022

This adds ClangFormat CI check.

To be merged after:

#2272

#2709
#2710
#2711
#2712
#2713
#2714
#2715

@nilason nilason added this to the 8.3.0 milestone Dec 22, 2022
@nilason
Copy link
Contributor Author

nilason commented Dec 22, 2022

@wenzeslaus Any thoughts on this? Would be good to have this formatting check active as soon as possible.

wenzeslaus
wenzeslaus approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. jidicula/clang-format-action CI code is actually shorter than some of the alternatives. Previously committed version detected issues, so it seems it works. Thanks.

@nilason
Copy link
Contributor Author

nilason commented Dec 23, 2022

This looks good. jidicula/clang-format-action CI code is actually shorter than some of the alternatives. Previously committed version detected issues, so it seems it works. Thanks.

Thank you, for taking a look at this!

@nilason nilason merged commit 237814f into OSGeo:main Dec 23, 2022
@nilason nilason deleted the add_clang-format_CI-check branch February 14, 2023 10:31
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
CI: add ClangFormat check (OSGeo#2716)
41e9ccb
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@nilason @neteler
CI: add ClangFormat check (OSGeo#2716)
5036f20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nilason @wenzeslaus