Docker alpine image patch to work with py3.8 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related discussion: https://trac.osgeo.org/grass/ticket/3880#comment:5 |
|
To remain operative, I'll merge this now. |
neteler
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
Backported to relbr78 in 00afb78 |
|
Note that the patch for gisinit.c is not needed, actually it is doing more harm than good. The real bug is in the generated ctypes when using Python 3.8 where not a full string is returned but only the first character of a string. That means, instead of comparing "$Revision$" with "$Revision$", the string "$" is compared to "$Revision$". |
neteler
added a commit
that referenced
this pull request
Jan 11, 2020
* docker alpine: removed gisinit revision workaround gisinit revision patch in #278 obsoleted by ec9b6f2 See: https://trac.osgeo.org/grass/ticket/3880 (also improves #117)
neteler
added a commit
that referenced
this pull request
Jan 11, 2020
* docker alpine: removed gisinit revision workaround gisinit revision patch in #278 obsoleted by ec9b6f2 See: https://trac.osgeo.org/grass/ticket/3880 (also improves #117)
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jan 28, 2020
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jan 28, 2020
* docker alpine: removed gisinit revision workaround gisinit revision patch in OSGeo#278 obsoleted by ec9b6f2 See: https://trac.osgeo.org/grass/ticket/3880 (also improves OSGeo#117)
petrasovaa
pushed a commit
to petrasovaa/grass
that referenced
this pull request
Feb 18, 2020
petrasovaa
pushed a commit
to petrasovaa/grass
that referenced
this pull request
Feb 18, 2020
* docker alpine: removed gisinit revision workaround gisinit revision patch in OSGeo#278 obsoleted by ec9b6f2 See: https://trac.osgeo.org/grass/ticket/3880 (also improves OSGeo#117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some extensions cannot be installed. With these Dockerfile patches for alpine and python3.8, they can be installed again.