Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/history: Move Export History button to history pane #3402

Conversation

lindakarlovska
Copy link
Contributor

@lindakarlovska lindakarlovska commented Feb 4, 2024

This PR relocates the Export History button placed at the bottom of the Console pane to the History pane at the top.

Before:
Screenshot from 2024-02-04 20-05-23

After:
Screenshot from 2024-02-04 20-02-08

@lindakarlovska lindakarlovska added enhancement New feature or request GUI wxGUI related labels Feb 4, 2024
@lindakarlovska lindakarlovska added this to the 8.4.0 milestone Feb 4, 2024
@github-actions github-actions bot added the Python Related code is in Python label Feb 4, 2024
@petrasovaa
Copy link
Contributor

Moving it to history makes sense. What I am unsure about is the placement of the button, right now it looks like it's related to the search (see advanced search in Tools tab), which is problematic, also because it doesn't export the filtered history if I understand it correctly. I would expect it to be at the bottom, below the history, no?

@lindakarlovska
Copy link
Contributor Author

Moving it to history makes sense. What I am unsure about is the placement of the button, right now it looks like it's related to the search (see advanced search in Tools tab), which is problematic, also because it doesn't export the filtered history if I understand it correctly. I would expect it to be at the bottom, below the history, no?

Yes, you are right, that is better.

@lindakarlovska
Copy link
Contributor Author

Screenshot from 2024-02-06 13-07-45
I've put it to the bottom on the left, we can change the position also later once we add more buttons.
Could I merge it?

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the button to the right (like in Tools tab)? Otherwise this is good to go!

@petrasovaa
Copy link
Contributor

Also, it's minor, but wouldn't it be better to have Save and Clear buttons besides each other in the console tab (on the right)?

@lindakarlovska lindakarlovska force-pushed the wxGUI-move-export-history-button-to-history-pane branch from 52a8582 to 9a3e45c Compare February 7, 2024 07:40
@lindakarlovska lindakarlovska merged commit d85d987 into OSGeo:main Feb 7, 2024
25 checks passed
jadenabrams100 pushed a commit to ncsu-csc472-spring2024/grass-CI-playground that referenced this pull request Feb 21, 2024
Export History button moved from the Console pane to the bottom of the History pane

---------

Co-authored-by: lindakladivova <l.kladivova@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants