r.horizon: variable needs to be reset for point mode #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
github-actions
bot
added
Python
nilason
approved these changes
Feb 22, 2024
petrasovaa
added a commit
that referenced
this pull request
Feb 22, 2024
The bug is that for part of the angles it results in zeros. It comes up when there are nulls at the edge of the raster, test was added.
|
Thanks for the review! Backported to be part of 8.3.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bug coming from using global variables in r.horizon. Reported by a user, can be reproduced with https://www.datigeo-piem-download.it/static/regp01/DTM5_ICE/RIPRESA_AEREA_ICE_2009_2011_DTM-SDO_CTR_FOGLI50-172-EPSG32632-TIF.zip:
The bug is that for part of the angles it results in zeros. It comes up when there are nulls at the edge of the raster, test was added.
This bug is not present in #3346, there it was (accidentally) fixed.