Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIS_H_DATE: switch to date -Iseconds format #485

Merged
merged 5 commits into from Apr 24, 2020
Merged

Conversation

landam
Copy link
Member

@landam landam commented Apr 4, 2020

@landam landam added the enhancement New feature or request label Apr 4, 2020
@landam landam added this to the 7.8.3 milestone Apr 4, 2020
@landam landam requested review from HuidaeCho and metzm April 4, 2020 14:32
@landam
Copy link
Member Author

landam commented Apr 4, 2020

Both build_date and libgis_date changed to date -Iseconds format.

g.version -rg
...
build_date=2020-04-04T16:29:44
...
libgis_date=2020-03-31T20:34:57+02:00

@landam
Copy link
Member Author

landam commented Apr 4, 2020

Note, build_date has no timezone info.

general/g.version/main.c Outdated Show resolved Hide resolved
general/g.version/main.c Outdated Show resolved Hide resolved
include/version.h.in Outdated Show resolved Hide resolved
general/g.version/main.c Outdated Show resolved Hide resolved
@HuidaeCho
Copy link
Member

Not directly related to this commit... What is @(#) below in version.h?

#define GRASS_VERSION_STRING   "@(#) 7.9.dev (2020)"

@landam
Copy link
Member Author

landam commented Apr 4, 2020

Not directly related to this commit... What is @(#) below in version.h?

#define GRASS_VERSION_STRING   "@(#) 7.9.dev (2020)"

No idea.

@HuidaeCho
Copy link
Member

Not directly related to this commit... What is @(#) below in version.h?

#define GRASS_VERSION_STRING   "@(#) 7.9.dev (2020)"

No idea.

Maybe, it's a relic from the old days? If so and we don't know why it's there, safe to remove it in another PR?

@neteler
Copy link
Member

neteler commented Apr 4, 2020

#define GRASS_VERSION_STRING "@(#) 7.9.dev (2020)"

Maybe, it's a relic from the old days? If so and we don't know why it's there, safe to remove it in another PR?

Might be, from an old code versioning system?

I see in the code:

ag '@\(#\)'
vector/v.extract/extract.c
1:/*  @(#)xtract_lines.c    1.0  9/29/89   

lib/vector/diglib/prune.c
18:/*  @(#)prune.c 3.0  2/19/98  */

lib/manage/element_list
1:# @(#)Element_List

raster/r.out.bin/gmt_grd.h
3: *    The GMT-system:	@(#)gmt_grd.h	3.18  01/13/00

raster/r.proj/r.proj.h
1:/* @(#)r.proj.h v1.2 - 27 Jun 1995      -emes- */

raster/r.in.bin/gmt_grd.h
3: *    The GMT-system:	@(#)gmt_grd.h	3.18  01/13/00

include/version.h.in
1:#define GRASS_VERSION_STRING   "@(#) @GRASS_VERSION_NUMBER@ (@GRASS_VERSION_DATE@)"

Prior to CVS (end of 1999 introduced) something else was used for a while at CERL (and elsewhere, for the 3rd party software pieces).

I guess, @(#) can be removed.

configure.in Outdated Show resolved Hide resolved
Co-Authored-By: Huidae Cho <grass4u@gmail.com>
@neteler
Copy link
Member

neteler commented Apr 18, 2020

@landam shall this be included in 7.8.3 yet?

@landam
Copy link
Member Author

landam commented Apr 19, 2020

@landam shall this be included in 7.8.3 yet?

git log issue must be solved. I don't see this PR as a blocker for 7.8.3.

@landam
Copy link
Member Author

landam commented Apr 19, 2020

I guess, @(#) can be removed.

See #528

@landam landam merged commit f89b009 into OSGeo:master Apr 24, 2020
@landam landam deleted the date_seconds branch April 24, 2020 11:32
landam added a commit that referenced this pull request Apr 24, 2020
Co-authored-by: Huidae Cho <grass4u@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants