v.neighbors: add aggegate statistics on attribute colum [NEW FUNCTIONALITY] #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteler
reviewed
Apr 21, 2020
Co-Authored-By: Markus Neteler <neteler@gmail.com>
|
If you rebase your branch to the latest master, your checks will work again (changes unrelated to this PR). With that, this would be worth adding some tests for the interface, for the computation, or both. |
|
This PR also provides a fix for #535 |
metzm
reviewed
Apr 24, 2020
metzm
reviewed
Apr 24, 2020
mlennert
changed the title
|
If there are no objections I will merge this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #515 and proposes the addition of aggregate statistics based on an attribute of the point map. It also adds the where and cat options to use only selected points.