wxGUI: fix layout flags needed for wxPython 4.1.0 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the position was based on the order of adding panes, which was platform dependent. Now, a fixed position is supplied.
petrasovaa
force-pushed
the
fix-wx-assertion-sizer-flags
branch
from
b9e225a
to
d0de4b2
Compare
This was referenced May 16, 2020
|
Just attempted to test release branch 7.8 with wxPython 4.1 and was initially surprised by the many layout flag asserts that made GRASS unusable. I then realised this PR hasn't been backported yet. I think wxPython 4.1 support is crucial for the 7.8.4 release. It would be really great if this could be backported as soon as possible, to be able to continue testing. |
petrasovaa
added a commit
that referenced
this pull request
Aug 14, 2020
|
I forgot about it, backported now, please test. |
Great, will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With wxPython 4.1.0 there has been changes in enforcing correct layout flag usage. So most of GUI is affected. Also addresses other new AssertionErrors.
This is WIP, there are still issues with running GUI, some of them are unfortunately serious.