v.distance: Linear matrix becomes default, new -s flag for square matrix [API change] #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for square matrix
ninsbl
reviewed
May 8, 2020
ninsbl
approved these changes
May 8, 2020
|
Can this be merged ? |
mlennert
changed the title
|
Small note: I like the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is commits a patch that has been in trac for years (#3638). It changes v.distances default API.
Up to now, when using the -pa flag for printing the output of a complete matrix, this matrix would default to a square matrix. This is not always the easiest form for reuse, and it also means that you cannot use -pa with more than one upload option.
This PR makes the linear matrix default for all output forms, and allows multiple upload options even with -a. A new -s allows the user to request a square matrix when only one upload option is requested.