Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wx gui location wizard map picture removed #657

Conversation

lindakarlovska
Copy link
Contributor

@lindakarlovska lindakarlovska commented May 20, 2020

Before:
Screenshot from 2020-05-20 12-09-40

After:
Screenshot from 2020-05-20 15-29-13

The file and matches have been finding using: tree -f | grep loc_wizard_qgis.png and grep -IrnE loc_wizard_qgis.png . No other matches.

@petrasovaa
Copy link
Contributor

Is this PR supposed to replace #646?

@lindakarlovska
Copy link
Contributor Author

Is this PR supposed to replace #646?

It is not associated only with the first page but with the whole Location wizard. Therefore, I made different PR. But we can replace it. No problem.

@wenzeslaus
Copy link
Member

@lindakladivova I think what @petrasovaa is saying is that there is a lot of other changes on the branch you used for the PR. It seems you did git checkout -b from the other branch you are doing changes at, not from master. This is not a big deal, just confusion. There is couple of things you can do, but at this point you can just wait with this branch until the other PR is merged and then go from there. We can discuss the options and what would be the best workflow during our GSoC meeting.

@wenzeslaus wenzeslaus added the gsoc Reserved for Google Summer of Code student(s) label May 21, 2020
@lindakarlovska lindakarlovska force-pushed the wx-gui-Location-wizard-map-picture-removed branch from 7544527 to 2750b1b Compare May 23, 2020 02:09
@lindakarlovska lindakarlovska force-pushed the wx-gui-Location-wizard-map-picture-removed branch from 2750b1b to d4221be Compare May 23, 2020 02:34
@landam landam added the GUI wxGUI related label May 23, 2020
@petrasovaa petrasovaa self-requested a review May 30, 2020 01:33
@petrasovaa petrasovaa merged commit fa3ffb7 into OSGeo:master May 30, 2020
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants