wxGUI location wizard: EPSG page

[lindakarlovska]

Path to usr/share/proj/epsg was removed. Search and EPSG code text inputs were merged into one search input. Link to epsg.io was added. The layout was adapted using several box sizers instead of grid sizer.

Before:

Version 1:

The motion of events is following (unincorporated yet in Version 1):

• searching in a list on the fly
• choose automatically the first row and permit "next" button
• if epsg code is empty, nothing is selected and "next" button is not active
• change informative URL according to a query string

Version 2:

Already incorporated:

• searching in a list on the fly
• if epsg code is empty, nothing is selected and "next" button is not active
• change informative URL according to a query string

I have a problem that when selecting epsg code from a table, it sometimes happens that neither the query string nor the final epsg code mentioned in the summary page changes. Also I am not sure how to incorporate choosing the automatically the first row in the list.

Version 3 (Layout enhancement):

[lucadelu]

I'm not sure to remove completely the capability to use local epsg file. There could be specific coordinate system in local epsg file that are not in epsg.io

I suggest to change "Link to epsg.io:" in "Source:" with default value "epsg.io" with a button "Local epsg file" (or "Browse") to select the epsg file and change the source.

What do you think?

[mlennert]

I'm not sure to remove completely the capability to use local epsg file. There could be specific coordinate system in local epsg file that are not in epsg.io

I suggest to change "Link to epsg.io:" in "Source:" with default value "epsg.io" with a button "Local epsg file" (or "Browse") to select the epsg file and change the source.

What do you think?

The idea here is not to remove the use of the local epsg file. It is still used. The idea is that in 95% of cases users do not have to change this and that in the 5% of cases where it has to be changed, users know what they are doing and can simply set the relevant environment variable.

[mlennert]

Path to usr/share/proj/epsg was removed. Search and EPSG code text inputs were merged into one search input. Link to epsg.io was added. This link responds to the selection of EPSG code.

What do you mean by "responds to the selection of EPSG code" ?

Is the idea that if the user wants to search for all projection systems relevant for Ghana that she has to go to epsg.io, search there and then copy over the epsg code ?

I think we should avoid dependency on an internet connection, and so I would like to keep the possibility to search with keywords and not only epsg codes. I thought the idea was to just combine everything into one 'search' field where the user could enter either epsg codes or keywords ?

[petrasovaa]

I reviewed the page layout and suggest the following changes (diff against the last state):

--- a/gui/wxpython/location_wizard/wizard.py
+++ b/gui/wxpython/location_wizard/wizard.py
@@ -1553,8 +1553,7 @@ class EPSGPage(TitledPage):
 
         # epsg.io hyperlink
         self.tlink = HyperlinkCtrl(
-            self, id=wx.ID_ANY, 
-            size=(200, -1),
+            self, id=wx.ID_ANY,
             label="epsg.io",
             url="epsg.io")
         self.tlink.SetNormalColour(
@@ -1566,26 +1565,19 @@ class EPSGPage(TitledPage):
         
         # layout       
         searchBoxSizer.Add(self.lcode, proportion=0,
-                       flag=wx.ALIGN_LEFT |
-                       wx.ALIGN_CENTER_VERTICAL |
+                       flag=wx.ALIGN_CENTER_VERTICAL |
                        wx.ALL, border=5)
         searchBoxSizer.Add(self.searchb, proportion=1,
-                       flag=wx.ALIGN_LEFT |
-                       wx.ALIGN_CENTER_VERTICAL |
-                       wx.ALL, border=5)
+                       flag=wx.ALL, border=5)
         epsglistBoxSizer.Add(self.epsglist, proportion=1,
-                       flag=wx.ALIGN_LEFT |
-                       wx.ALIGN_CENTER_VERTICAL |
-                       wx.EXPAND |
+                       flag=wx.EXPAND |
                        wx.ALL, border=5)
-        informationBoxSizer.AddStretchSpacer(10) 
+        informationBoxSizer.AddStretchSpacer(1) 
         informationBoxSizer.Add(self.llink,  proportion=0,
-                       flag=wx.ALIGN_RIGHT |
-                       wx.ALIGN_CENTER_VERTICAL |
+                       flag=wx.ALIGN_CENTER_VERTICAL |
                        wx.ALL, border=5)
-        informationBoxSizer.Add(self.tlink, proportion=1,
-                       flag=wx.ALIGN_RIGHT |
-                       wx.ALIGN_CENTER_VERTICAL |
+        informationBoxSizer.Add(self.tlink, proportion=0,
+                       flag=wx.ALIGN_CENTER_VERTICAL |
                        wx.ALL, border=5)

Mostly the problem is with the flags, some of the combinations are throwing errors with latest wxPython. My suggestion for future is to not use wx.ALIGN_... and add them only when you see the need, rather then to put them everywhere 'just in case'. Also typically we don't specify fixed sizes of widgets.

[petrasovaa]

Some small improvements to the layout:

@@ -1568,21 +1568,21 @@ class EPSGPage(TitledPage):
                        flag=wx.ALIGN_CENTER_VERTICAL |
                        wx.ALL, border=5)
         searchBoxSizer.Add(self.searchb, proportion=1,
-                       flag=wx.ALL, border=5)
+                       flag=wx.ALL | wx.EXPAND, border=5)
         epsglistBoxSizer.Add(self.epsglist, proportion=1,
                        flag=wx.EXPAND |
                        wx.ALL, border=5)
         informationBoxSizer.AddStretchSpacer(1) 
         informationBoxSizer.Add(self.llink,  proportion=0,
                        flag=wx.ALIGN_CENTER_VERTICAL |
-                       wx.ALL, border=5)
-        informationBoxSizer.Add(self.tlink, proportion=1,
-                       flag=wx.ALIGN_CENTER_VERTICAL |
-                       wx.ALL, border=5)
+                       wx.RIGHT, border=5)
+        informationBoxSizer.Add(self.tlink, proportion=0,
+                       flag=wx.ALIGN_CENTER_VERTICAL)
         
         self.sizer.Add(searchBoxSizer, proportion=0, flag=wx.EXPAND)
         self.sizer.Add(epsglistBoxSizer, proportion=1, flag=wx.EXPAND)
-        self.sizer.Add(informationBoxSizer, proportion=0, flag=wx.EXPAND)
+        self.sizer.Add(informationBoxSizer, proportion=0,
+                       flag=wx.EXPAND | wx.TOP, border=5)

More importantly, the selection of the item in list needs to be fixed. We talked about automatic selection of the item after users starts to search (first in the list for simplicity, but we may want to do something more complex regarding preferring direct epsg match). The search box should not be updated upon selection in the list.