wxGUI loc wizard: Correct errors according to flake 8 and add some description #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…402,E821,E722 ignored), added some description.
wenzeslaus
requested changes
Jun 23, 2020
Comment on lines
2683
to
2694
| # datum = self.datumpage.datum | ||
| if self.datumpage.datumdesc: | ||
| datumdesc = self.datumpage.datumdesc + ' - ' + self.datumpage.ellipse | ||
| else: | ||
| datumdesc = '' | ||
| # datum = self.datumpage.datum | ||
| # if self.datumpage.datumdesc: | ||
| # datumdesc = self.datumpage.datumdesc + ' - ' + self.datumpage.ellipse | ||
| # else: | ||
| # datumdesc = '' | ||
|
|
There was a problem hiding this comment.
I don't see a reason why this code should be kept there and there is no comment saying that either, so I would say just delete that.
wenzeslaus
approved these changes
Jun 25, 2020
…lake8-in-wizard.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wxGUI/Location Wizard: Corrected errors according to flake8 (errors E402,E821,E722 ignored), added some description.