wxGUI/Data catalog: distinguish label and name of nodes

[lindakarlovska]

wxGUI/datacatalog: node.label changed to node.data['name'] in tree.py.

[petrasovaa]

You need to rebase and solve conflict with master. When you are in this PR branch do something like (always read git status to check):

git fetch upstream
git rebase upstream/master
# resolve conflicts in tree.py
git add tree.py
git rebase --continue
git push -f

[petrasovaa]

Renaming map doesn't work.

[petrasovaa]

You don't need to reload the entire tree to refresh the one layer.

[petrasovaa]

Which exception are you trying to catch here? Raised in _getNewMapName or Rename?

[petrasovaa]

Remove it or explain why it needs to be there.

[lindakarlovska]

You don't need to reload the entire tree to refresh the one layer.

I have tried to use self.RefreshNode(self.selected_layer[0]) instead of self.ReloadTreeItems but it does not work.
So, I should probably make the function self.ReloadSelectedLayer similar to self.ReloadCurrentMapset which would reload only selected layer. And similarly I could make other functions like self.ReloadSelectedMapset etc.. which might be used in other rename/delete functions further on.
But I am not sure how to make self.ReloadSelectedLayer since there is some process:
p = Process(
target=getLocationTree,
args=(
self.current_grassdb_node.data['name'],
self.current_location_node.data['name'],
q,
self.current_mapset_node.data['name']))...
in which a layer does not appear.

[lindakarlovska]

You don't need to reload the entire tree to refresh the one layer.

I have tried to use self.RefreshNode(self.selected_layer[0]) instead of self.ReloadTreeItems but it does not work.
So, I should probably make the function self.ReloadSelectedLayer similar to self.ReloadCurrentMapset which would reload only selected layer. And similarly I could make other functions like self.ReloadSelectedMapset etc.. which might be used in other rename/delete functions further on.
But I am not sure how to make self.ReloadSelectedLayer since there is some process:
p = Process(
target=getLocationTree,
args=(
self.current_grassdb_node.data['name'],
self.current_location_node.data['name'],
q,
self.current_mapset_node.data['name']))...
in which a layer does not appear.

Would be probably nice to have one general function for reloading which will reload everything recursively according to type of a node parameter?...

[petrasovaa]

You don't need to reload the entire tree to refresh the one layer.

I have tried to use self.RefreshNode(self.selected_layer[0]) instead of self.ReloadTreeItems but it does not work.
So, I should probably make the function self.ReloadSelectedLayer similar to self.ReloadCurrentMapset which would reload only selected layer. And similarly I could make other functions like self.ReloadSelectedMapset etc.. which might be used in other rename/delete functions further on.
But I am not sure how to make self.ReloadSelectedLayer since there is some process:
p = Process(
target=getLocationTree,
args=(
self.current_grassdb_node.data['name'],
self.current_location_node.data['name'],
q,
self.current_mapset_node.data['name']))...
in which a layer does not appear.

Reloading single layer is different than mapset/location/db. For this PR just change the node.label. We will address this in future differently.

[lindakarlovska]

I had an idea to changed ReloadTreeItems() in create/rename/delete functions to self.Refresh(self.selected_"node"[0], recursive=True) but it does not work. Seems to me that refreshing is different from reloading and for reload, the function _initTreeItems is needed.

[petrasovaa]

I had an idea to changed ReloadTreeItems() in create/rename/delete functions to self.Refresh(self.selected_"node"[0], recursive=True) but it does not work. Seems to me that refreshing is different from reloading and for reload, the function _initTreeItems is needed.

Yes, that's different. I suggest to review in depth the implementation of TreeModel and TreeView and AbstractTreeViewMixin. Basically, refreshing just influences rendering of the nodes, reloading changes the actual underlying data model.