-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI: Add new location action to database node in Data tab #790
wxGUI: Add new location action to database node in Data tab #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic functionality works for me, but there is couple issues I tried to describe in the comments.
Additionally, I tried changing the database directory in the location wizard and that caused some confusion in data catalog. GUI freezes and in command line I got "LOCATION </tmp/nc_spm> not available...access: No such file or directory" where /tmp/nc_spm is a combo of the database from the location wizard and nc_spm is a name of the current loation, but in different database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are additional comments based on your change and my further analysis.
…ate_location_interactively added. Also checking for location validation a bit changed, made more clear. After clicking on grass node, two options for creating and downloading location are avaliable.
…d_location_interactively corrected. In the function create_location_interactively tuple is returned instead of actual GUI. Function import_file is moved to guiutils.py as a seperate function.
…to create_location_interactively. Flake8 corrected. The error after hitting cancel in Location Wizard corrected.
…into create_location_interactively. Default mapset is PERNAMENT or could be the result of create_mapset_interactively. Function download_location_interactively was adapted in terms of interface with the create_location_interactively. Still error related to the change of grassdatabase within location wizard.
… from OnCreateLocation. InsertLocation removed as well. Tried to add grass database to datacatalog within OnWizFinished function but I am not sure if I do it well.
9e611e7
to
48bf628
Compare
You search the tree in tree.py. Use SearchNodes functions, plenty of examples in tree.py. |
…node exists. Flake8 corrected.
Now, it should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. This works for me as expected. Can you please go through the comments and make sure they are all addressed and comment on them how they were addressed?
…ively and create_location_interactively added. Changed function OnCreateLocation in gis_set.py.


wxGUI/datacatalog: New functions download_location_interactively, create_location_interactively added. Also checking for location validation a bit changed, made more clear. After clicking on grass node, two options for creating and downloading location are avaliable.