Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: Changes in Layer Manager tabs order and labels #802

Merged
merged 1 commit into from
Jul 23, 2020
Merged

wxGUI: Changes in Layer Manager tabs order and labels #802

merged 1 commit into from
Jul 23, 2020

Conversation

lindakarlovska
Copy link
Contributor

@lindakarlovska lindakarlovska commented Jul 18, 2020 •
edited
Loading

wxGUI/LayerManager: Changed tab order (Modules are third) and Layers renamed to Display.

@mlennert
Copy link
Contributor

As one can open more than one display, I would call the tab 'Displays'.

@petrasovaa
Copy link
Contributor

As one can open more than one display, I would call the tab 'Displays'.

I thought about that and I still feel Display is better, since it's more general (meaning displaying as a concept) and many people don't use multiple displays anyway. But I don't have strong opinion on it.

petrasovaa
petrasovaa approved these changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once we agree on Display(s).

@petrasovaa petrasovaa added gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related labels Jul 19, 2020
@petrasovaa petrasovaa added this to In progress in New GUI Startup via automation Jul 19, 2020
@wenzeslaus wenzeslaus added the help wanted Extra attention is needed label Jul 20, 2020
@wenzeslaus
Copy link
Member

Anybody has opinions about naming the tab Display versus Displays? The current name is Layers.

@wenzeslaus wenzeslaus linked an issue Jul 20, 2020 that may be closed by this pull request
[Feat] Changes in Layer Manager tabs order and labels #799
Closed
@neteler
Copy link
Member

neteler commented Jul 20, 2020

If possible, @lindakladivova : could you pls add a screenshot here illustrating your proposal? thx

@nilason
Copy link
Contributor

nilason commented Jul 21, 2020

To me, Display (as a verb) seems most appropriate.

@lindakarlovska
Copy link
Contributor Author

Here is the suggestion:

Screenshot from 2020-07-21 11-48-52

@neteler
Copy link
Member

neteler commented Jul 22, 2020

I like "Display" best.

@mlennert
Copy link
Contributor

mlennert commented Jul 22, 2020 via email

@petrasovaa petrasovaa merged commit 1ea5afe into OSGeo:master Jul 23, 2020
New GUI Startup automation moved this from PRs in progress to Done Jul 23, 2020
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related help wanted Extra attention is needed
Projects
No open projects
New GUI Startup
  
Done
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[Feat] Changes in Layer Manager tabs order and labels
6 participants
@lindakarlovska @mlennert @petrasovaa @wenzeslaus @neteler @nilason