Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Add new icons to data catalog for actions avaliable in context menu #811

Conversation

lindakarlovska
Copy link
Contributor

@lindakarlovska lindakarlovska commented Jul 20, 2020

Certain actions that are currently available (and will be available in the future) in the context menus of data catalog need to be exposed as toolbar icons. This is a suggested list of actions, to be edited based on discussion and feature availability:

  • add new database (already created)
  • create new mapset (now created)

Other:

  • download sample location
  • create new location
  • import into current mapset

@lindakarlovska lindakarlovska marked this pull request as draft July 20, 2020 17:56
@wenzeslaus wenzeslaus linked an issue Jul 20, 2020 that may be closed by this pull request
@wenzeslaus wenzeslaus added this to In progress in New GUI Startup via automation Jul 20, 2020
@petrasovaa petrasovaa added gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related labels Jul 21, 2020
@petrasovaa
Copy link
Contributor

There is already an icon mapset-add.png in grass you can use.
To create location-add icon, combine QGIS icons mIconOws.svg and mActionAdd.svg
To create download location icon, use the import symbol (like in grass layer-import.png) - the svg of that can be found in qgis mAddToProject.svg.

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this works, this is not what we discussed. In tree.py you need to create a function CreateMapset that would be called from OnCreateMapset in tree.py, catalog.py and frame.py, which are all event handlers just differing in how they get the parameters for CreateMapset, which does the actual work of creating the mapset and adding it to the tree.

@petrasovaa petrasovaa linked an issue Jul 23, 2020 that may be closed by this pull request
5 tasks
lindakladivova and others added 4 commits July 23, 2020 10:53
…alled from tree.py, catalog.py and frame.py
* fix create_mapset_interactively
* change CreateMapset to take nodes
* remove unnecessary try except
* remove unused imports
* delete icon code for future icons that are not working yet
@petrasovaa petrasovaa marked this pull request as ready for review July 24, 2020 03:00
@petrasovaa petrasovaa merged commit 1781132 into OSGeo:master Jul 24, 2020
New GUI Startup automation moved this from PRs in progress to Done Jul 24, 2020
@petrasovaa
Copy link
Contributor

@lindakladivova I edited it (I suggest to look at the changes) and merged it to finish this for now. Create a new PR for the location icons.

@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Feat] Add new icons to data catalog for actions available in context menu
3 participants