Data catalog: double click on map from different location fails #886
Conversation
…y maps outside the current location.
lindakarlovska
added
GUI
There was a problem hiding this comment.
Good catch ! Does this issue only arise through double-click ?
However, I'm not sure it is a good idea to allow the user to switch directly to the other location and the display the map.
This raises the more general question, linked to new central role of the data catalog, of how to handle the display of maps from different locations in the same Display window. IMHO, this should be avoided, and the user clearly informed.
So, in the specific issue raised here, IMHO the user should just be informed that the map is in a different location and cannot be displayed. Possibly we could inform the user on how to switch locations.
|
That's a good point of course, we discussed this with @wenzeslaus and for now let's go with @mlennert's suggestion. It is also consistent with the fact, you can't display layer from other location through context menu. For future (not this PR) it would make sense to have a custom dialog allowing not just switching to that mapset but also reprojection. |
…h do not allow to display the map contained by the different than current location.
gui/wxpython/datacatalog/tree.py
Outdated
| "The map is not in the current location and cannot be displayed." | ||
| "\n\n" | ||
| "To view this map, switch to the selected mapset." | ||
| ), | ||
| caption=_("Unable to display the map"), |
There was a problem hiding this comment.
Let's make the message little bit more specific:
"Map <mymap@mapset> is not in the current location and therefore cannot be displayed. \n\n To display this map switch to mapset <mapset> first."
Describe the bug
Double click on map from different than current location adds the layer into layer tree but the layer does not exist in current location so it fails to display it.
Expected behavior
I suppose it should inform user that the map is in different location and ask if they want to switch to that mapset.