Reflect changes when mapset/location is created from menu #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindakarlovska
added
bug
petrasovaa
reviewed
Aug 20, 2020
gui/wxpython/lmgr/frame.py
Outdated
Comment on lines
1065
to
1066
| db_node, loc_node, mapset_node = self.datacatalog.tree.GetCurrentDbLocationMapsetNode() | ||
| self.datacatalog.tree.CreateMapset(db_node, loc_node) |
There was a problem hiding this comment.
This should call create_mapset_interactively directly, not through datacatalog. As for the reloading of datacatalog, for now just call self.datacatalog.tree.ReloadTreeItems() and we will later change this using signals.
…vely called directly.
petrasovaa
reviewed
Aug 21, 2020
gui/wxpython/lmgr/frame.py
Outdated
| GError(parent=self, | ||
| message=_("No mapset provided. Operation canceled.")) | ||
| return | ||
| db_node, loc_node, mapset_node = self.datacatalog.tree.GetCurrentDbLocationMapsetNode() |
There was a problem hiding this comment.
Just get the current location and db from gisenv
petrasovaa
reviewed
Aug 21, 2020
petrasovaa
reviewed
Aug 21, 2020
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
petrasovaa
reviewed
Aug 23, 2020
|
#994 incorporated the changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several actions that need to be synced in GUI and datacatalog. This PR solves the case when the mapset/location is created from menu.