wxGUI datacatalog: add direct editing of mapset and location name #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
added
gsoc
This was
linked to
issues
Aug 20, 2020
petrasovaa
requested changes
Aug 21, 2020
petrasovaa
requested changes
Aug 21, 2020
wenzeslaus
reviewed
Aug 21, 2020
petrasovaa
requested changes
Aug 23, 2020
…from guiutils.py), also existing functions as get_reason_mapset_removable moved to checks.py. get_reason_grassdb_removable was not moved because of GetListOfLocations function. MapsetDialog and LocationDialog a bit changed, now it uses GenericValidator instread of MultiGenericValidator.
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
lindakarlovska
force-pushed
the
wxGUI-add-direct-editing-of-mapset-and-location-name
branch
from
77da00e
to
ead598f
Compare
…ditions in OnStartEditLabel made more straightforward.
petrasovaa
reviewed
Aug 24, 2020
petrasovaa
reviewed
Aug 24, 2020
petrasovaa
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses both #917, #918.
#918:
Currently we can rename map by selecting it and clicking at it again, which opens an editing window (like in any file manager). This should work also for mapsets and locations. It should take into account if the restricted mode is on or off.
#917:
In datacatalog when we select a map in other mapset and click on it second time to open editing window, you can rename it even when restricted mode is on. This should not be permitted.