Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Add VERTCON .gtx grids (fixes https://github.com/OSGeo/proj.4/issues/1071) #23

Merged
merged 1 commit into from Jul 12, 2018

Conversation

rouault
Copy link
Member

@rouault rouault commented Jul 10, 2018

Those grids have been converted from the original NOAA grids with
the provided vertcon_94_to_gtx.py script.

Check

$ echo "-98.4803739 29.4667897 0" | ~/proj/proj.4//src/cct +proj=pipeline +step +proj=vgridshift +multiplier=0.001 +ellps=GRS80 +grids=./vertconc.gtx
-98.4803739000   29.4667897000        0.1288           inf

which is consistant with the EPSG database for epsg_coordoperationmethod = 9658 :

Then using bi-linear interpolation for 29.4667897°N, 98.4803739°W, offset = 0.129m

@sebastic
Copy link
Collaborator

The vertcon_94_to_gtx.py should probably be added to CPACK_SOURCE_IGNORE_FILES in north-america/CMakeLists.txt to not have it included in the archive, and hence not extracted to $PROJ_DATA when unpacking the archive.

@rouault
Copy link
Member Author

rouault commented Jul 10, 2018

The vertcon_94_to_gtx.py should probably be added to CPACK_SOURCE_IGNORE_FILES

Good point. Commit amended

@sebastic sebastic requested a review from kbevers July 10, 2018 16:12
@sebastic
Copy link
Collaborator

I think this is good to merge now. Added @kbevers for a second opinion.

@kbevers
Copy link
Member

kbevers commented Jul 11, 2018

Also looks good to me but since this PR was opened we decided to go a different way in PROJ as seen here: OSGeo/PROJ#1072

So, with the addition of a grid value multiplier it is really not necessary to include the grids with updated units. I suggested adding them here before Even came up with the multiplier idea which I think is a better solution to this problem.

The original grids with mm units can still be added here.

Those grids have been converted from the original NOAA grids with
the provided vertcon_94_to_gtx.py script.
They require PROJ 5.2 to do the +multiplier=0.001 operation to convert
from millimeter to meter.
@rouault rouault changed the title Add VERTCON .gtx grids with offsets in meter (fixes https://github.com/OSGeo/proj.4/issues/1071) Add VERTCON .gtx grids (fixes https://github.com/OSGeo/proj.4/issues/1071) Jul 12, 2018
@rouault
Copy link
Member Author

rouault commented Jul 12, 2018

OK, I've reworked the script to let the values in millimeters

@kbevers kbevers merged commit d9347d4 into OSGeo:master Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants