Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error unless ACCEPT_USE_OF_DEPRECATED_PROJ_API_H is #define'd #836

Closed
kbevers opened this Issue Mar 5, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@kbevers
Copy link
Member

kbevers commented Mar 5, 2018

From version 6.0.0 proj_api.h will be deprecated. proj_api.h will not be included as a public header file from PROJ 7.0.0 and onwards. We want to make that clear from version 6.0.0 by requiring that users that want to use proj_api.h #define a macro like ACCEPT_USE_OF_DEPRECATED_PROJ_API_H. If the macro is not defined a compile-time error should be raised declaring that the user is including a deprecated API.

@kbevers kbevers added this to the 6.0.0 milestone Mar 5, 2018

kbevers added a commit to kbevers/proj.4 that referenced this issue Sep 18, 2018

Only allow usage of proj_api.h if explicit consent was given
We want to flag that proj_api_h is now deprecated. With this commit
it is now mandatory to #define ACCEPT_USE_OF_DEPRECATED_PROJ_API_H
before proj_api.h can be included.

proj_api.h is used internally a bunch of places. Therefore
ACCEPT_USE_OF_DEPRECATED_PROJ_API_H has been defined in projects.h
and a few other necessary files to ensure that PROJ compiles.

Closes OSGeo#836

kbevers added a commit to kbevers/proj.4 that referenced this issue Sep 18, 2018

Only allow usage of proj_api.h if explicit consent was given
We want to flag that proj_api_h is now deprecated. With this commit
it is now mandatory to #define ACCEPT_USE_OF_DEPRECATED_PROJ_API_H
before proj_api.h can be included.

proj_api.h is used internally a bunch of places. Therefore
ACCEPT_USE_OF_DEPRECATED_PROJ_API_H has been defined in projects.h
and a few other necessary files to ensure that PROJ compiles.

Closes OSGeo#836

kbevers added a commit to kbevers/proj.4 that referenced this issue Sep 18, 2018

Only allow usage of proj_api.h if explicit consent was given
We want to flag that proj_api_h is now deprecated. With this commit
it is now mandatory to #define ACCEPT_USE_OF_DEPRECATED_PROJ_API_H
before proj_api.h can be included.

proj_api.h is used internally a bunch of places. Therefore
ACCEPT_USE_OF_DEPRECATED_PROJ_API_H has been defined in projects.h
and a few other necessary files to ensure that PROJ compiles.

Closes OSGeo#836

@kbevers kbevers closed this in 66f228c Sep 19, 2018

@Komzpa

This comment has been minimized.

Copy link

Komzpa commented Dec 17, 2018

Hello,
I can't get Proj master working with PostGIS trunk. Please advise.
https://github.com/postgis/postgis/pull/354/files

@kbevers

This comment has been minimized.

Copy link
Member Author

kbevers commented Dec 17, 2018

Does the problem go away if you what's suggested in this comment: https://github.com/postgis/postgis/pull/354/files#r242068366

@Komzpa

This comment has been minimized.

Copy link

Komzpa commented Dec 17, 2018

Thank you. It's now working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.